Skip to content

bin/crates-admin: Convert to async #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

bin/crates-admin: Convert to async #9579

merged 2 commits into from
Oct 4, 2024

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

This makes it easier to use async-only APIs in the admin tools and convert more functions to use diesel_async internally.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
@codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 390 lines in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (828f52e) to head (13dd11a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/render_readmes.rs 0.00% 77 Missing ⚠️
src/admin/enqueue_job.rs 0.00% 61 Missing ⚠️
src/admin/delete_version.rs 0.00% 59 Missing ⚠️
src/admin/delete_crate.rs 0.00% 46 Missing ⚠️
src/admin/upload_index.rs 0.00% 43 Missing ⚠️
src/admin/default_versions.rs 0.00% 21 Missing ⚠️
src/admin/migrate.rs 0.00% 21 Missing ⚠️
src/admin/test_pagerduty.rs 0.00% 18 Missing ⚠️
src/bin/crates-admin.rs 0.00% 13 Missing ⚠️
src/admin/verify_token.rs 0.00% 10 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9579      +/-   ##
==========================================
- Coverage   89.10%   88.96%   -0.14%     
==========================================
  Files         289      289              
  Lines       29057    29101      +44     
==========================================
  Hits        25890    25890              
- Misses       3167     3211      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 429e1be into rust-lang:main Oct 4, 2024
10 checks passed
@Turbo87 Turbo87 deleted the async-admin branch October 4, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Turbo87